Dev-server - display fullscreen Cockpit login form #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
reviewed
Nov 2, 2023
There was a problem hiding this comment.
I wonder why do you want this change. I mean, I see no problem on having the Cockpit login form wrapped into the Agama layout at all. It's perfectly usable.
That said, I have no problem of going ahead with the proposed change as long as it only applies when working in the development mode, but I'd like to know the rationale of it.
Ah, I guess if for having a similar experience than in production. |
dgdavid
approved these changes
Nov 2, 2023
|
Yes, the reason is to have the very same look as in production. It's a bit confusing when you are presenting a demo using the development server... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
iframe), with the Agama main page styling appliedSolution
Notes
It is a bit hack, but as this is applied only in the development server (not in production) I think it is acceptable. Otherwise we would need to change the HTML structure and CSS quite a lot...